Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests/e2e-POC #7

Merged
merged 35 commits into from
Dec 5, 2024
Merged

Tests/e2e-POC #7

merged 35 commits into from
Dec 5, 2024

Conversation

canlopes
Copy link
Contributor

Issue / feature description

Quick description of the issue or the feature that is implemented in the pr ie: add new transitions between screens

Changes

quick list regarding the related changes within the pr

ie:

  • add new transaction transformer
  • add new ui

Checklist

  • Rebased to the last commit of the target branch (or merged)
  • Code self-reviewed
  • Code self-tested
  • Tests updated (if needed)
  • All tests are passing locally

Please keep your pull request as small as possible. If you need to make multiple changes, please create separate pull requests for each change. Create a draft pull request if you need early feedback. This will mark the pull request as a work in progress and prevent it from being reviewed or merged until you are ready.

Please move drafts to the ready for review (regular PR) when you are ready to start the review process and other developers will pick it up from there.

Copy link

vercel bot commented Nov 12, 2024

@canlopes is attempting to deploy a commit to the argentlabs team on Vercel, but is not a member of this team. To resolve this issue, you can:

  • Make your repository public. Collaboration is free for open source and public repositories.
  • Add @canlopes as a member. A Pro subscription is required to access Vercel's collaborative features.
    • If you're the owner of the team, click here and add @canlopes as a member.
    • If you're the user who initiated this build request, click here to request access.
    • If you're already a member of the argentlabs team, make sure that your Vercel account is connected to your GitHub account.

To read more about collaboration on Vercel, click here.

* develop:
  chore: add get-starknet-core dep
  chore: bump starknekit version
  chore: rollback pnpm-lock.yaml
  feat: enable mm support
  chore: update ui
  chore: update ui
Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
demo-dapp-starknet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 11:15am

@bluecco bluecco marked this pull request as ready for review December 5, 2024 12:09
@bluecco bluecco merged commit 1f72402 into develop Dec 5, 2024
5 checks passed
@bluecco bluecco deleted the tests/e2e-POC branch December 5, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants